Testem #181
Open
Testem #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…buttons /select fields where end dash will try to set the value based on a scope but the children haven't been parsed yet so it will error... for example:
```html
<div class="present-">
<select class="usersId-">
<optgroup data-scope="/users" data-each>
<option value="#{id}" class="name-"></option>
</optgroup>
</select>
</div>
```
When we traverse and get to the select.userId- we try to set val() on it, but the users have not yet populated.
This is not the "best" fix, but at least it allows the template to completely render before trying to set val().
|
Can one of the admins verify this patch? |
|
test please On Friday, December 6, 2013, amicus-jenkins wrote:
Brian Glusman - [email protected] |
|
totally won't run anymore. |
cd end-dash
npm install
npm install -g testem
testemopen http://localhost:7357 in a browser. The tests just ran in the browser, boom. |
|
Before this can get merged:
I think we should completely replace the current jsdom tests with this. |
|
hmm - I think we should close this PR till it's ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run all the tests with testem.
We can use this once testem/testem#324 gets merged. It still works without it but sometimes all the tests dont run.